Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On old pythons typing.Type can cause unexpected errors -> deactivate #106

Merged
merged 1 commit into from
Nov 16, 2018
Merged

On old pythons typing.Type can cause unexpected errors -> deactivate #106

merged 1 commit into from
Nov 16, 2018

Conversation

penguinolog
Copy link
Collaborator

MyPy will still check types, while in normal runtime type will be string
Use scm versioning

@penguinolog
On old pythons typing.Type can cause unexpected errors -> deactivate
bf0e82b 
MyPy will still check types, while in normal runtime type will be string

Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog penguinolog added bug Something isn't working enhancement New feature or request labels Nov 16, 2018
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 313

  • 3 of 9 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 98.95%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/init.py 3 9 33.33%
Totals Coverage Status
Change from base Build 310: -0.5%
Covered Lines: 1225
Relevant Lines: 1238
💛 - Coveralls

2 similar comments
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 313

  • 3 of 9 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 98.95%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/init.py 3 9 33.33%
Totals Coverage Status
Change from base Build 310: -0.5%
Covered Lines: 1225
Relevant Lines: 1238
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Nov 16, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 313

  • 3 of 9 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 98.95%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/init.py 3 9 33.33%
Totals Coverage Status
Change from base Build 310: -0.5%
Covered Lines: 1225
Relevant Lines: 1238
💛 - Coveralls

@penguinolog penguinolog merged commit cd77add into python-useful-helpers:master Nov 16, 2018
@penguinolog penguinolog deleted the typing_py35 branch November 16, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

@espositocloud espositocloud Awaiting requested review from espositocloud

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@penguinolog @coveralls