Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Race condition on process kill: sometimes FIFO are still open #107

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Fix: Race condition on process kill: sometimes FIFO are still open #107

merged 2 commits into from
Nov 27, 2018

Conversation

penguinolog
Copy link
Collaborator

Log critical if readers are still running.
Allow exception on stream close (do not handle) to protect from leak.
Primary use SIGTERM for graceful shutdown, then retry with SIGKILL

@penguinolog penguinolog added the bug Something isn't working label Nov 27, 2018
Log critical if readers are still running.
Allow exception on stream close (do not handle) to protect from leak.
Primary use SIGTERM for graceful shutdown, then retry with SIGKILL
@coveralls
Copy link
Collaborator

coveralls commented Nov 27, 2018

Pull Request Test Coverage Report for Build 318

  • 8 of 11 (72.73%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 99.303%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/subprocess_runner.py 7 10 70.0%
Totals Coverage Status
Change from base Build 309: -0.3%
Covered Lines: 998
Relevant Lines: 1005

💛 - Coveralls

@penguinolog penguinolog merged commit 12b18d1 into python-useful-helpers:py27 Nov 27, 2018
@penguinolog penguinolog deleted the fifo_close_check branch November 27, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants