Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mass backport from master #111

Merged
merged 5 commits into from
Nov 28, 2018
Merged

Mass backport from master #111

merged 5 commits into from
Nov 28, 2018

Conversation

penguinolog
Copy link
Collaborator

No description provided.

@penguinolog
On old pythons typing.Type can cause unexpected errors -> deactivate
2bbfcd8 
MyPy will still check types, while in normal runtime type will be string

Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>

(cherry picked from commit cd77add)
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog
rm .eggs
a2fb527 
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>

(cherry picked from commit c7aa77a)
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog
Fix: Race condition on process kill: sometimes FIFO are still open
b7dfbb2 
Log critical if readers are still running.
Allow exception on stream close (do not handle) to protect from leak.
Primary use SIGTERM for graceful shutdown, then retry with SIGKILL

(cherry picked from commit b66f1b5)
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog
travis deploy: no sdist conflict
c5a0c4d 
(cherry picked from commit 3feec6f)
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog
Rework exceptions
0072639 
1. Allow substitute `CalledProcessError`
2. Modify exceptions class hierarchy
3. Expose **kwargs in stable places
4. Temporary disable black formatter: due to bug it's destroy py35

Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>

(cherry picked from commit 46b2009)
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog penguinolog added bug Something isn't working enhancement New feature or request governance Technical, not related to documentation and functionality. labels Nov 28, 2018
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 338

  • 39 of 47 (82.98%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 98.772%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/subprocess_runner.py 10 12 83.33%
exec_helpers/init.py 3 9 33.33%
Totals Coverage Status
Change from base Build 301: -0.8%
Covered Lines: 1046
Relevant Lines: 1059
💛 - Coveralls

@penguinolog penguinolog merged commit 8e79fed into python-useful-helpers:py34 Nov 28, 2018
@penguinolog penguinolog deleted the bp_34 branch November 28, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

@espositocloud espositocloud Awaiting requested review from espositocloud

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request governance Technical, not related to documentation and functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@penguinolog @coveralls