Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop ssh connection caching. Fix #132 #135

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Stop ssh connection caching. Fix #132 #135

merged 3 commits into from
Jul 3, 2019

Conversation

penguinolog
Copy link
Collaborator

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@penguinolog
Stop ssh connection caching. Fix #132
9835579 
Signed-off-by: Aleksei Stepanov <penguinolog@gmail.com>
@penguinolog
Stop ssh connection caching. Fix #132
664addd 
Signed-off-by: Aleksei Stepanov <penguinolog@gmail.com>
@penguinolog
black
774be8e 
Signed-off-by: Aleksei Stepanov <penguinolog@gmail.com>
@penguinolog penguinolog added this to In progress in Support python-ssh2 as faster ssh backend via automation Jul 3, 2019
@penguinolog penguinolog added this to In progress in Support sshconfig handling via automation Jul 3, 2019
@penguinolog penguinolog added the enhancement New feature or request label Jul 3, 2019
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 599

  • 10 of 10 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 97.599%
Files with Coverage Reduction New Missed Lines %
exec_helpers/_ssh_client_base.py 1 97.96%
Totals Coverage Status
Change from base Build 592: -0.08%
Covered Lines: 1177
Relevant Lines: 1192
💛 - Coveralls

1 similar comment
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 599

  • 10 of 10 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 97.599%
Files with Coverage Reduction New Missed Lines %
exec_helpers/_ssh_client_base.py 1 97.96%
Totals Coverage Status
Change from base Build 592: -0.08%
Covered Lines: 1177
Relevant Lines: 1192
💛 - Coveralls

@penguinolog penguinolog merged commit b9f469c into master Jul 3, 2019
Support python-ssh2 as faster ssh backend automation moved this from In progress to Done Jul 3, 2019
Support sshconfig handling automation moved this from In progress to Done Jul 3, 2019
@penguinolog penguinolog deleted the caching branch July 3, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

@espositocloud espositocloud Awaiting requested review from espositocloud

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Support python-ssh2 as faster ssh bac...
  
Done
Support sshconfig handling
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@penguinolog @coveralls