Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial ssh config support. Partial: #133 Partial: #134 #136

Merged
merged 5 commits into from Nov 13, 2019
Merged

Initial ssh config support. Partial: #133 Partial: #134 #136

merged 5 commits into from Nov 13, 2019

Conversation

penguinolog
Copy link
Collaborator

temporary disabled part of sftp tests: all sftp tests should be re-written from scratch

@penguinolog
Initial ssh config support. Partial: #133 Partial: #134
cc39aca 
temporary disabled part of sftp tests: all sftp tests should be re-written from scratch
@penguinolog penguinolog added the enhancement New feature or request label Nov 13, 2019
@penguinolog penguinolog added this to In progress in Support sshconfig handling via automation Nov 13, 2019
@coveralls
Copy link
Collaborator

coveralls commented Nov 13, 2019 •
edited

Pull Request Test Coverage Report for Build 649

  • 141 of 147 (95.92%) changed or added relevant lines in 2 files are covered.
  • 30 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-4.08%) to 93.493%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/_ssh_helpers.py 131 137 95.62%
Files with Coverage Reduction New Missed Lines %
exec_helpers/ssh_client.py 30 15.79%
Totals Coverage Status
Change from base Build 639: -4.08%
Covered Lines: 2573
Relevant Lines: 2700
💛 - Coveralls

@penguinolog penguinolog merged commit 4804796 into master Nov 13, 2019
Support sshconfig handling automation moved this from In progress to Done Nov 13, 2019
@penguinolog penguinolog deleted the WIP_sshconfig branch November 13, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

@espositocloud espositocloud Awaiting requested review from espositocloud

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Support sshconfig handling
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@penguinolog @coveralls