inspect.Parameter.empty is a class and can be used as singleton. Fix #35

(#37) Fix & bump Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
python-useful-helpers · Aug 14, 2018 · 47fd1aa · 47fd1aa
1 parent e27c917
commit 47fd1aa
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/logwrap/__init__.py b/logwrap/__init__.py
@@ -43,7 +43,7 @@
     'bind_args_kwargs'
 )
 
-__version__ = '5.0.0'
+__version__ = '5.0.1'
 __author__ = "Alexey Stepanov"
 __author_email__ = 'penguinolog@gmail.com'
 __maintainers__ = {

diff --git a/logwrap/_log_wrap.py b/logwrap/_log_wrap.py
@@ -133,7 +133,7 @@ def __str__(self) -> str:
             as_str += ': {annotation!s}'.format(annotation=inspect.formatannotation(self.annotation))
 
         value = self.value
-        if self.empty == value:
+        if self.empty is value:
             if self.VAR_POSITIONAL == self.kind:
                 value = ()
             elif self.VAR_KEYWORD == self.kind:
@@ -549,7 +549,7 @@ def _get_func_args_repr(
             else:
                 value = param.value
 
-            if param.empty == value:
+            if param.empty is value:
                 if param.VAR_POSITIONAL == param.kind:
                     value = ()
                 elif param.VAR_KEYWORD == param.kind:
@@ -568,7 +568,7 @@ def _get_func_args_repr(
                 param_str += comment(kind=param.kind)
                 last_kind = param.kind
 
-            if param.empty == param.annotation:
+            if param.empty is param.annotation:
                 annotation = ""
             else:
                 annotation = "  # type: {param.annotation!s}".format(param=param)

diff --git a/logwrap/_repr_utils.py b/logwrap/_repr_utils.py
@@ -493,9 +493,9 @@ def _repr_callable(
                 indent=self.next_indent(indent),
                 param=param
             )
-            if param.annotation != param.empty:
+            if param.annotation is not param.empty:
                 param_str += ': {param.annotation}'.format(param=param)
-            if param.value != param.empty:
+            if param.value is not param.empty:
                 param_str += '={val}'.format(
                     val=self.process_element(
                         src=param.value,
@@ -509,7 +509,7 @@ def _repr_callable(
             param_str += "\n" + " " * indent
 
         sig = inspect.signature(src)
-        if sig.return_annotation == inspect.Parameter.empty:
+        if sig.return_annotation is inspect.Parameter.empty:
             annotation = ''
         else:
             annotation = ' -> {sig.return_annotation!r}'.format(sig=sig)
@@ -666,9 +666,9 @@ def _repr_callable(
                 indent=self.next_indent(indent),
                 param=param
             )
-            if param.annotation != param.empty:
+            if param.annotation is not param.empty:
                 param_str += ': {param.annotation}'.format(param=param)
-            if param.value != param.empty:
+            if param.value is not param.empty:
                 param_str += '={val}'.format(
                     val=self.process_element(
                         src=param.value,
@@ -682,7 +682,7 @@ def _repr_callable(
             param_str += "\n" + " " * indent
 
         sig = inspect.signature(src)
-        if sig.return_annotation == inspect.Parameter.empty:
+        if sig.return_annotation is inspect.Parameter.empty:
             annotation = ''
         else:
             annotation = ' -> {sig.return_annotation!r}'.format(sig=sig)