Fix pylint and make micro optimization

python-useful-helpers · Oct 16, 2019 · 5f6f904 · 5f6f904
1 parent 1ddd524
commit 5f6f904
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 70 deletions.
diff --git a/.pylintrc b/.pylintrc
@@ -62,84 +62,19 @@ confidence=
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use "--disable=all --enable=classes
 # --disable=W".
-disable=print-statement,
-        parameter-unpacking,
-        unpacking-in-except,
-        old-raise-syntax,
-        backtick,
-        long-suffix,
-        old-ne-operator,
-        old-octal-literal,
-        import-star-module-level,
+disable=import-star-module-level,
         non-ascii-bytes-literal,
         raw-checker-failed,
         bad-inline-option,
         locally-disabled,
         file-ignored,
         suppressed-message,
         useless-suppression,
-        deprecated-pragma,
         use-symbolic-message-instead,
-        apply-builtin,
-        basestring-builtin,
-        buffer-builtin,
-        cmp-builtin,
-        coerce-builtin,
-        execfile-builtin,
-        file-builtin,
-        long-builtin,
-        raw_input-builtin,
-        reduce-builtin,
-        standarderror-builtin,
-        unicode-builtin,
-        xrange-builtin,
-        coerce-method,
-        delslice-method,
-        getslice-method,
-        setslice-method,
         no-absolute-import,
         old-division,
-        dict-iter-method,
-        dict-view-method,
-        next-method-called,
-        metaclass-assignment,
-        indexing-exception,
-        raising-string,
-        reload-builtin,
-        oct-method,
-        hex-method,
-        nonzero-method,
-        cmp-method,
-        input-builtin,
-        round-builtin,
-        intern-builtin,
-        unichr-builtin,
-        map-builtin-not-iterating,
-        zip-builtin-not-iterating,
-        range-builtin-not-iterating,
-        filter-builtin-not-iterating,
-        using-cmp-argument,
-        eq-without-hash,
-        div-method,
-        idiv-method,
-        rdiv-method,
-        exception-message-attribute,
         invalid-str-codec,
-        sys-max-int,
-        bad-python3-import,
-        deprecated-string-function,
-        deprecated-str-translate-call,
-        deprecated-itertools-function,
-        deprecated-types-field,
         next-method-defined,
-        dict-items-not-iterating,
-        dict-keys-not-iterating,
-        dict-values-not-iterating,
-        deprecated-operator-function,
-        deprecated-urllib-function,
-        xreadlines-attribute,
-        deprecated-sys-function,
-        exception-escape,
         comprehension-escape,
         similarities,
         too-many-ancestors,
@@ -154,7 +89,8 @@ disable=print-statement,
         misplaced-comparison-constant,
         bad-continuation,
         broad-except,
-        logging-fstring-interpolation
+        logging-fstring-interpolation,
+        logging-format-interpolation
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

diff --git a/logwrap/log_on_access.py b/logwrap/log_on_access.py
@@ -476,11 +476,11 @@ def __name__(self) -> str:
         """Name getter."""
         return (
             self.override_name or self.fget.__name__
-            if self.fget
+            if self.fget is not None
             else self.fset.__name__
-            if self.fset
+            if self.fset is not None
             else self.fdel.__name__
-            if self.fdel
+            if self.fdel is not None
             else ""
         )