Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling colons in ipv6 #107

Closed
devikasondhi opened this issue Dec 26, 2018 · 3 comments · Fixed by #201
Closed

Handling colons in ipv6 #107

devikasondhi opened this issue Dec 26, 2018 · 3 comments · Fixed by #201

Comments

@devikasondhi
Copy link

Invalid address 1111: is flagged as valid by the ipv6 validator

@devikasondhi
Copy link
Author

Cases with leading colons are also not handled for cases as below:
":8888"
":1.2.3.4"

These are invalid ipv6 addresses but the validator on ipv6 returns True

@kvesteri
Copy link
Collaborator

PRs welcome

@SimonIT
Copy link
Contributor

SimonIT commented Feb 15, 2022

"18:05" returns also True

SimonIT added a commit to SimonIT/validators that referenced this issue Feb 15, 2022
SimonIT added a commit to SimonIT/validators that referenced this issue Feb 15, 2022
SimonIT added a commit to SimonIT/validators that referenced this issue Feb 15, 2022
kvesteri pushed a commit that referenced this issue May 4, 2022
* Improve IPv6 validation
fixes #107

* Add some comments

* Fix ipv4 with double colon

* Fix falsy to long ipv6 result and detect to long parts

* Check for length

* Take empty parts in account

* Reduce length calculation
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Jun 19, 2022
https://build.opensuse.org/request/show/982861
by user mia + dimstar_suse
- Update to 0.20.0
  * Add ipv4 digit lenghts validation
    (gh#python-validators/validators#191)
  * Fix error with international URLs that have more than 2 hyphens
    (gh#python-validators/validators#184)
Changes in 0.19.0:
  * Improve IPv6 validation
    (gh#python-validators/validators#201 gh#python-validators/validators#107)
  * Drop support for Python 3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants