-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build_ext
fails if build_py
was not called before
#296
Comments
Ensure that `build_py` command is always called prior to `build_ext`. The distutils/setuptools build systems do not guarantee (or require) calling `build_py`, therefore versioneer fails to find .py files if `build_ext` is called immediately on a fresh source tree. Closes python-versioneer#296
During standard I note that we do avoid running the update if you use |
Building in-place is not an option for us, as separate build dirs are required to handle different versions of Python. |
For the record, the problem is related to the Python build infrastructure for Gentoo packages. I suppose the alternative "fix" would be to skip updating the version if |
Might make sense to warn if the file doesn't exist with an error message that explains that it couldn't be updated and you might need to Setup.py does also allow you to pass multiple commands, each with their own options. For this use case, maybe:
|
The whole point is to avoid calling |
Your PR proposes including I think the file check and warning is probably the right way to go for your use case. |
Ok, I'll update the PR later today. |
Skip version update on `build_ext` command if the respective version file does not exist. This could be the case if `build_ext` is called explicitly without calling `build_py` prior to it. Closes python-versioneer#296
…and updated! |
Skip version update on `build_ext` command if the respective version file does not exist. This could be the case if `build_ext` is called explicitly without calling `build_py` prior to it. Closes python-versioneer#296
Skip version update on `build_ext` command if the respective version file does not exist. This could be the case if `build_ext` is called explicitly without calling `build_py` prior to it. Closes python-versioneer#296
For example in aesara:
The text was updated successfully, but these errors were encountered: