Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for pathlib object #103

Merged
merged 2 commits into from
Feb 15, 2022
Merged

support for pathlib object #103

merged 2 commits into from
Feb 15, 2022

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Oct 29, 2021

PR for this issue: #102

saving object can take pathlib object

@wd60622
Copy link
Contributor Author

wd60622 commented Feb 14, 2022 •
edited

The Path object is the parent class for both Window's and non-Window's machines. https://github.com/python/cpython/blob/04215a427232e55efdc1adcda50a15197f518ca9/Lib/pathlib.py#L853-L871

Any other steps required here? @Conengmo

@Conengmo Conengmo merged commit b58682d into python-visualization:master Feb 15, 2022
@Conengmo
Copy link
Member

Nice addition, thanks Will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conengmo Conengmo Conengmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wd60622 @Conengmo @wbdean