More flexible _parse_size #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conengmo
force-pushed
the
more-flexible-parse-size
branch
from
ab34f09
to
8d97a55
Compare
ocefpaf
reviewed
Dec 1, 2022
| if isinstance(value, (int, float)): | ||
| return float(value), "px" | ||
| elif isinstance(value, str): | ||
| match = re.fullmatch(r"([\d.]+)\s?(\w{1,5}|%)", value.strip()) |
There was a problem hiding this comment.
I'm not a regex expert but testing it with online tools seems to work as expect. The firs t is supposed to be the number and the second one the %, right?
There was a problem hiding this comment.
that's right! I added a comment to clarify
ocefpaf
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to pass a value in pixels to the width and height parameters of
Map, but found I couldn't. That seemed weird to me. Turns out there are two issues:_parse_sizeonly allows an integer, which it interprets as pixels, or something like '80 %'. It doesn't allow '800 px', which I think it should._parse_size.Lengths in CSS can have many units other than '%' or 'px': https://developer.mozilla.org/en-US/docs/Web/CSS/length. I think we should trust our users to know what unit they want to use. Change
_parse_sizeto allow any unit. Add tests.Other
In another change in folium I'll propose we'll remove the duplicate utility functions and use the ones from branca instead: python-visualization/folium#1676
Why does
_parse_sizereturn the value and the unit separately? It makes our templates more verbose. We could just as well make it convert integers to strings, then returning those. But that's a bigger change.