Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jinja2 version constraint #156

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

tomboehling
Copy link
Contributor

Branca does not work with some older versions of Jinja2, resulting in an ImportError: cannot import name 'soft_unicode' from 'markupsafe' (for e.g. import branca.colormap as colormap). To address this issue, we have added a version constraint for Jinja2>=3.

Branca does not work with some older versions of Jinja2, resulting in an `ImportError: cannot import name 'soft_unicode' from 'markupsafe'` (for e.g. `import branca.colormap as colormap`). To address this issue, we have added a version constraint for `Jinja2>=3`.
Copy link
Collaborator

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomboehling
Copy link
Contributor Author

Thank you for your quick response, @martinfleis! Could you please create a release after merging this?

@martinfleis
Copy link
Collaborator

@Conengmo do you want to do a patch release with this and #145?

@ocefpaf
Copy link
Member

ocefpaf commented Jan 30, 2024

@Conengmo do you want to do a patch release with this and #145?

I can do that today. Working on it now...

@ocefpaf ocefpaf merged commit 3b9966b into python-visualization:main Jan 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants