Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove split_six utility function #161

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented Apr 3, 2024

This utility function is not used anywhere in Branca or Folium. It sort of requires Pandas, which is not actually a dependency of Branca. By removing this function, we can also remove that awkward import of Pandas.

  • This function was included in the first version, but was not used at that time as well.
  • It's also not included in the documentation.
  • I couldn't find a reference to it using Github's search function.

I think we're pretty safe to remove it, since I don't expect it will have downstream users. If there are downstream users, they can easily adopt the code themselves, since it's just a few lines.

Copy link
Collaborator

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

@Conengmo
Copy link
Member Author

Conengmo commented Apr 3, 2024

Thanks Martin for the review!

@Conengmo Conengmo merged commit 32cd619 into python-visualization:main Apr 3, 2024
11 checks passed
@Conengmo Conengmo deleted the remove-split-six branch April 3, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants