Drop Py3.7, add Py3.12 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
reviewed
Apr 4, 2024
| python-version: "3.9" | ||
| - os: ubuntu-latest | ||
| python-version: "3.10" | ||
| os: [ubuntu-latest, windows-latest] |
There was a problem hiding this comment.
Any specific reason why you dropped macOS from the matrix?
There was a problem hiding this comment.
We're not running those on Folium as well. I'd like to make Folium and Branca more consistent, so it's easier to update both. And I figured with a Linux and Windows test, we got the two main flavors covered. Would you agree or do you think we should keep Macos and add it to the Folium tests as well?
There was a problem hiding this comment.
I suppose that with neither branca or folium we may likely run into macOS-specific issues so I guess it is fine. I just wanted to make sure it is intentional.
There was a problem hiding this comment.
Thanks Martin, appreciate you looking out!
martinfleis
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just did the same in Folium in python-visualization/folium#1917.
Also simplify the matrix for the code tests a bit and make it the same as in Folium. This will making upgrading this in the future easier, since we can just copy it.