Use a srcdoc attribute on iframes #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstein64
commented
Jun 18, 2021
|
Awesome! I’m gonna review it ASAP |
ocefpaf
reviewed
Jun 18, 2021
Conengmo
approved these changes
Jun 19, 2021
There was a problem hiding this comment.
Even though Notebooks still have to be trusted for the maps to load, I still like this change because it's a simplification. And who knows, maybe it will be better in some other applications if we don't rely on JS anymore to load the map html.
@dstein64 if you have no more comments I'll go ahead and merge this.
I have no more comments. Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #66, updating
iframes to now usesrcdoc. Support forsrcdocwas added to Microsoft Edge shortly after that PR. Internet Explorer still does not supportsrcdoc, but that browser is being phased out (support ends June 15, 2022).