Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data does not fail gracefully #7

Closed
wrobstory opened this issue Jun 18, 2013 · 3 comments
Closed

Missing data does not fail gracefully #7

wrobstory opened this issue Jun 18, 2013 · 3 comments

Comments

@wrobstory
Copy link
Contributor

For Choropleth maps, if the GeoJSON and JSON data do not match, the color defaults to the highest in the scale. It would be preferable for it to default to white, in order to recognize that the value is missing.

wrobstory added a commit that referenced this issue Jun 19, 2013
@wrobstory
Copy link
Contributor Author

Fixed in 8269f81

@scardine
Copy link

Defaulting to transparent could be more appropriate, because when you are using some color scale starting or ending in white the result is potentially misleading.

Having this as a parameter would be even better because it would allow for better legends.

There are several valid reasons for omitting data related to certain features, and you may want to show them distinctly:

  • anonymity and privacy concerns when the number of events is very small for some region
  • data not available
  • lack of events
  • not applicable

@wrobstory
Copy link
Contributor Author

Yep, all good points. I just changed it so that it defaults to null rather than #fff. Any data that isn't matched to a key is automatically "nulled", which causes that area to be blank.

Thank you!

Conengmo pushed a commit to Conengmo/folium that referenced this issue Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants