Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins object and a few plugins #151

Merged
merged 1 commit into from
Jul 27, 2015

Conversation

BibMartin
Copy link
Contributor

A few devs based on #145. We have :

  • A Plugin that other plugins can inherit from.
  • A TemplatePlugin object to develop simple plugins with jinja2.
  • A few examples (BoatMarker, Terminator, Layer).
  • A notebook of examples for the plugins.

@andrewgiessel
Copy link
Contributor

FWIW, Build fails due to lack of urllib2 on py3.3 and py3.4

@BibMartin BibMartin mentioned this pull request Jul 25, 2015
@BibMartin
Copy link
Contributor Author

I think this is ready for merge. @themiurgo, @ocefpaf do you think of a next step ? can you merge it, please ?

@ocefpaf
Copy link
Member

ocefpaf commented Jul 27, 2015

Outstanding work @BibMartin!! I am actually happy I procrastinated doing this for so you could come along and do it much better than I envisioned 😜

ocefpaf added a commit that referenced this pull request Jul 27, 2015
Plugins object and a few plugins
@ocefpaf ocefpaf merged commit df71c48 into python-visualization:plugins Jul 27, 2015
@ocefpaf
Copy link
Member

ocefpaf commented Jul 27, 2015

@BibMartin I just added you to folium team. We have only one rule: Avoid self-merges as much as you can. Welcome and thanks for this awesome PR!

@BibMartin
Copy link
Contributor Author

Thanks to you ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants