fix 212 #234
Merged
fix 212 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| and float legend labels. | ||
| freescale: if True use free format for the scale, where min and max | ||
| values are taken from the data. It also allow to plot allow to plot | ||
| values < 0 and float legend labels. | ||
|
|
There was a problem hiding this comment.
I guess there's a typo here, isn't it ?
you may keep the indent, and avoid the duplication of allow to plot
There was a problem hiding this comment.
Urgh! My pep8 stupid mindset attacks again.
|
Except the line 805-807 comment changes, I'm okay for the rest. |
|
Perfect. Squash ? |
|
Done. |
BibMartin
added a commit
that referenced
this pull request
Nov 3, 2015
|
Merged. 🔫 |
|
|
|
I am rethinking this one and I plan to revert it. This is a bad solution and we should just tell to people to start migrating to The problems are:
I guess the downsides are not worth fixing #212. |
This was referenced Nov 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BibMartin this is far from ideal because I am encoding only when there is no
self.json_data. But I do not want to holdv0.1.6and I want all our efforts to be onv0.2.0.