Refactor marker cluster #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Sep 3, 2017
| @@ -16,7 +16,7 @@ | |||
| from branca.element import (CssLink, Element, Figure, JavascriptLink, MacroElement) # noqa | |||
| from branca.utilities import (_locations_tolist, _parse_size, image_to_url, iter_points, none_max, none_min) # noqa | |||
|
|
|||
| from folium.map import FeatureGroup, Icon, Layer, Marker | |||
| from folium.map import FeatureGroup, Icon, Layer, Popup, Marker | |||
There was a problem hiding this comment.
F401 'folium.map.Popup' imported but unused
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
…ker_cluster Refactor marker cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MarkerClusterhad two different implementation, one infeaturesand another one inplugins.The former required an external loop, while the latter could take a list of objects.
I merged them into one that accepts both but I am leaning towards removing the external loop version b/c the list is virtually 100% equivalent.
markercluster 1.1.0icon_create_functionexample