Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.9.7 breaks tests #1051

Closed
aaugustin opened this issue Sep 19, 2021 · 3 comments · Fixed by #1089
Closed

Python 3.9.7 breaks tests #1051

aaugustin opened this issue Sep 19, 2021 · 3 comments · Fixed by #1089
Labels
blocked

Comments

@aaugustin
Copy link
Member

Tests fail due to https://bugs.python.org/issue45097. It will be fixed in 3.9.8. We could pin GitHub actions to 3.9.6 (and inevitably forget to unpin...) or just live with broken builds for two months, until GitHub actions gives us 3.9.8.
aaugustin added a commit that referenced this issue Sep 19, 2021
@aaugustin
Pin Python 3.9.6 in CI.
a95c668 
Ref #1051.
@aaugustin aaugustin mentioned this issue Sep 19, 2021
Merged
aaugustin added a commit that referenced this issue Sep 19, 2021
@aaugustin
Pin Python 3.9.6 in CI.
bbc55c5 
Ref #1051.
aaugustin added a commit that referenced this issue Sep 19, 2021
@aaugustin
Pin Python 3.9.6 in CI.
744482a 
Ref #1051.
@aaugustin
Copy link
Member Author

Revert around mid november 2021, when 3.9.8 is available on GitHub actions.

chylli-deriv added a commit to chylli-deriv/python-deriv-api-old that referenced this issue Sep 21, 2021
@chylli-deriv
swtich to 3.8 again because 3.9.7 has problem here: python-websockets…
440d3d3 
…/websockets#1051
@aaugustin aaugustin mentioned this issue Oct 30, 2021
Closed
@vfazio
Copy link

vfazio commented Nov 11, 2021

3.9.8 has been released https://www.python.org/downloads/release/python-398/

aaugustin added a commit that referenced this issue Nov 11, 2021
@aaugustin
Unpin Python 3.9.6.
ffbb186 
Reverts 744482a.

Fix #1051.
@aaugustin aaugustin mentioned this issue Nov 11, 2021
Merged
@aaugustin
Copy link
Member Author

Thank you.

aaugustin added a commit that referenced this issue Nov 11, 2021
@aaugustin
Unpin Python 3.9.6.
56b5893 
Reverts 744482a.

Fix #1051.
@chylli-deriv chylli-deriv mentioned this issue Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpin Python 3.9.6. python-websockets/websockets
2 participants
@aaugustin @vfazio