Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for the removal of tulip.task in 27985f4 #2

Closed
belug23 opened this issue Sep 4, 2013 · 3 comments
Closed

Account for the removal of tulip.task in 27985f4 #2

belug23 opened this issue Sep 4, 2013 · 3 comments

Comments

@belug23
Copy link

belug23 commented Sep 4, 2013

the wrapper task has been removed after revision 8c72a16d58a4

any revision after this one break websockets : https://code.google.com/p/tulip/source/browse/?r=8c72a16d58a4

@aaugustin
Copy link
Member

I'm following the Tulip mailing-list, I knew that tulip.task was going to be removed, and I had planned to make appropriate changes when it happens.

The commit that removes tulip.task is actually 27985f461839041c32652b435c846a046c697414 (with an unfortunate commit message).

https://code.google.com/p/tulip/source/detail?r=27985f461839041c32652b435c846a046c697414

I'm going to update the ticket title (previous title: after revision 8c72a16d58a4 of tulip it stoped working).

@aaugustin
Copy link
Member

This is actually an accident: https://groups.google.com/d/msg/python-tulip/roCARLfX1gU/W161oofUblwJ

@belug23
Copy link
Author

belug23 commented Sep 4, 2013

Ok sorry for the wrong revision number probably some problem installin the higher revision.

But now it's reverted in the master of tulip and working.

thanks for the link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants