Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install websockets installs asyncio 0.4 with python 3.4.0. #25

Closed
hardkrash opened this issue May 1, 2014 · 4 comments
Closed

pip install websockets installs asyncio 0.4 with python 3.4.0. #25

hardkrash opened this issue May 1, 2014 · 4 comments

Comments

@hardkrash
Copy link

Expectation is that with python 3.4.0 that the built in asyncio would be used, not an external module.

@Ivoz
Copy link
Contributor

Ivoz commented May 1, 2014

Do you have the latest version of websockets? This line should ensure you only get the pypi package if you're running python 3.3.

@Ivoz
Copy link
Contributor

Ivoz commented May 1, 2014

Ahhh, the problem is the wheel. setup.py is only run at build time, not install time, with wheels. So the install_requires keyword will only be valid for the python version that ran setup.py when the wheel was built. I made a PR to fix this #26

@aaugustin
Copy link
Member

I appreciate the time you took to rewrite setup.py entirely, but I don't understand everything you've done and the status of setup.cfg is still unclear to me. I think I'll just stop providing wheels.

@aaugustin
Copy link
Member

I've also removed the wheel from PyPI.

I may try wheels again in a few years when they're no longer bleeding edge technology where you need to follow pre-release docs, I don't have time for that.

aaugustin added a commit that referenced this issue Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants