Rename Connection to Protocol. #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the following naming possible: * Connection = TCP/TLS connection + pointer to protocol; concerned with opening the network connection, moving bytes, and closing it. * Protocol = Sans-I/O protocol; concerned with parsing and serializing messages and with the state of the connection. Previously, these names were reversed in the sockets & threads branch. The previous choice was influenced by the legacy implementation using "protocol" to describe the two layers together, itself influenced by asyncio using the same word.
aaugustin
added a commit
to aaugustin/sanic
that referenced
this pull request
Nov 27, 2022
aaugustin
added a commit
to aaugustin/sanic
that referenced
this pull request
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following naming possible:
Previously, these names were reversed in the sockets & threads branch.
The previous choice was influenced by the legacy implementation using "protocol" to describe the two layers together, itself influenced by asyncio using the same word.