Fix issue with matplotlib 3.6.0 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
force-pushed
the
fix_mpl_3.6.0
branch
2 times, most recently
from
f265c45
to
2806e9a
Compare
|
I'm converting this to draft for now b/c I want to add a simple regression test that compares images before we move forward. |
ocefpaf
force-pushed
the
fix_mpl_3.6.0
branch
from
2806e9a
to
ee69f14
Compare
|
This fix may cause issues with older versions of Matplotilb, see https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.6.0.html#axes-subclasses-should-override-clear-instead-of-cla Looking at what cartopy does may be a good reference. |
I tested with 3.5 but I'll test a bit more and pin mpl to a >= ver_that_work. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work with mpl >=3 b/c too, I updated the minimum requirement.
Closes #190