Expose GE Z-Wave in wall fan switch as a fan #105
Conversation
Wink recognizes this as a dimmer switch for some reason. But in reality it is just a fan switch with 3 speeds (translating to brightness levels of 33%, 66% and 100% in the dimmer switch). This patch extends WinkFan to specialize the case of GE Z-Wave in wall fan switch and exposes it as a fan instead of a light bulb. I've also added a sample json for the tests. This way home assistant will expose this as a fan without any changes on the user's part.
|
Will look this over this evening |
|
@bradsk88 sure, thanks! |
There was a problem hiding this comment.
Looks good to me.
One thing that comes to mind is that when I originally took ownership of this project, my intention was to have it act as a thin-wrapper for the Wink API.
That is to say: not having special logic like this.
I wonder if you could move some of this logic to live in a dedicated module. Something like special_cases.py or something...
Either way. Feel free to merge.
|
Thanks for the review!
The custom code has test coverage. So i didn't think it was necessary to put it in a custom module. There's also other custom logic (like exposing some cameras as sensors). So i think this is fine. :)
I don't have write access to this repo to merge. Could you please merge it? |
|
It was more of a stylistic request than any sort of acceptance criteria. Just a heads up that I'll probably try to refactor this to the way I described later. Behaviour should remain unchanged. |
|
Thanks! Could you please also create a new release on pypi so that i can import this into home assistant? |
|
@vickyg3 Sorry for the delay. Published! |
|
Thank you! :) The home assistant PR is here: home-assistant/core#14894 |
|
This is a very much appreciated HA improvement to Wink's silly grouping of this in-wall fan control as a light dimmer. However, for the two identical Wink "fans" I have using this GE/Jasco In-wall fan control, one is being recognized by Hassio perfectly as a fan and the other is not being properly recognized as either a light or fan and becomes an unusable entity. I will submit a detailed issue on this separately. |
|
To add further to the OP's comment "Wink recognizes this as a dimmer switch for some reason", I had contacted Wink support about it.
|
Ah i am sorry about that. I thought this was a safe change as it picked up only fans with a specific manufacturer_device_model. May be there are multiple devices with the same model? Could really help to have a sample device json to look into this further. |
|
It may just be an edge case of when a "fan speed" (aka light brightness) is zero that wink/fan.py is not expecting. Both fans are using the identical GE Zwave fan control. I'm not sure how to provide the device json, but here's the detail I see for each fan entity when they are set to either low, med, or high speed... entity: fan.den_ceiling_fan entity: fan.bedroom_ceiling_fan Both fans are working fine now - but as a test, I set each fan speed to as low as the slider will go via the Wink interface and restarted HASSIO. Yep, the wink/fan.py errors returned and now neither fan appears in the HASSIO interface. I would expect that you will be able to duplicate this. Thanks! ` |
|
Moving the discussion to #107. |
Wink recognizes this as a dimmer switch for some reason. But in
reality it is just a fan switch with 3 speeds (translating to
brightness levels of 33%, 66% and 100% in the dimmer switch).
This patch extends WinkFan to specialize the case of GE Z-Wave
in wall fan switch and exposes it as a fan instead of a light
bulb. I've also added a sample json for the tests.
This way home assistant will expose this as a fan without any
changes on the user's part.
Example device: https://www.amazon.com/GE-Controls-Required-SmartThings-14287/dp/B06XTKQTTV/ref=sr_1_1_sspa