Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode strings to utf-8 in ServiceInfo #10

Closed
wants to merge 1 commit into from

Conversation

jgrill
Copy link

@jgrill jgrill commented Dec 1, 2014

I found that properties dict values registered as "False" rather than the intended string value, such as "path" in the provided examples.

eg.

Service Paul's Test Web Site._http._tcp.local. added
Type is _http._tcp.local.
Address is 10.0.1.2:80
Weight is 0, Priority is 0
Server is ash-2.local.
Properties are
path: False

I found that properties dict values registered as "False" rather than the intended string value, such as "path" in the provided examples.

eg.

Service Paul's Test Web Site._http._tcp.local. added
  Type is _http._tcp.local.
  Address is 10.0.1.2:80
  Weight is 0, Priority is 0
  Server is ash-2.local.
  Properties are
    path: False
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) when pulling c2f05f1 on jgrill:master into 05c3c02 on jstasiak:master.

@jstasiak
Copy link
Collaborator

Thanks for the contribution. I fixed it in f3fd4cd while refactoring the code. Feel free to reopen if it doesn't work for you for any reason.

@jstasiak jstasiak closed this Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants