Avoid waking up ServiceInfo listeners when there is no new data #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to clean this up and add tests for it |
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
- Coverage 99.92% 99.80% -0.12%
==========================================
Files 23 23
Lines 2542 2557 +15
Branches 473 478 +5
==========================================
+ Hits 2540 2552 +12
- Misses 1 2 +1
- Partials 1 3 +2
Continue to review full report at Codecov.
|
bdraco
force-pushed
the
notify_only_add
branch
2 times, most recently
from
b34f653
to
8b6f7a7
Compare
- Currently we release the async_wait when we remove or update records but the listener only cares about new records non-nsec so we release and then wait again most of the time.
bdraco
changed the title
bdraco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
records but the listener only cares about new records non-nsec so we
release and then wait again most of the time.