Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup naming from previous refactoring in ServiceInfo #1202

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 24, 2023

There were still some places where we are using address which should be ip_addr

Remove some of the expensive isinstance checks as well.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fed3dec) 99.78% compared to head (5ecbbd4) 99.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1202   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          22       22           
  Lines        2729     2733    +4     
  Branches      473      473           
=======================================
+ Hits         2723     2727    +4     
  Misses          3        3           
  Partials        3        3           
Impacted Files Coverage Δ
src/zeroconf/_services/__init__.py 100.00% <ø> (ø)
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review July 24, 2023 16:04
@bdraco bdraco merged commit b272d75 into master Jul 24, 2023
34 checks passed
@bdraco bdraco deleted the var_names branch July 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant