feat: add a cache to service_type_name #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function gets call all over the place and when we construct a lot of ServiceInfos for queries its the most expensive part. Since we tend to query the same records over and over when a ServiceBrowser is running, this can have quite a cost
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1211 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 22 22
Lines 2749 2750 +1
Branches 477 478 +1
=======================================
+ Hits 2743 2744 +1
Misses 3 3
Partials 3 3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function gets called all over the place and when we construct a lot of ServiceInfos for queries its the most expensive part. Since we tend to query the same records over and over when a ServiceBrowser is running, this can have quite a cost