feat: speed up instances only used to lookup answers #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is nothing in the ServiceRegistry we would still process incoming questions. If we have no answers to give, we can skip the handling queries completely as it significantly reduces cpu time.
13 tasks
bdraco
force-pushed
the
avoid_query_path_empty_registry
branch
from
3b9e5e8
to
7c05293
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know! |
|
That dropped the esphome background cpu quite a bit. How did I miss this for so many years? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is nothing in the ServiceRegistry we would still process incoming questions. If we have no answers to give, we can skip the handling of queries completely as it significantly reduces cpu time.
This is expected to significantly reduce cpu time for one shot usage and consumers that only use zeroconf to lookup answers.