Merge pull request #744 from jeblair/revert-close

Revert "Fix possible endless wait in stop() after AUTH_FAILED error (…
python-zk · Mar 6, 2024 · 8269235 · 8269235
2 parents b4155ea + 2fb93a8
commit 8269235
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/kazoo/protocol/connection.py b/kazoo/protocol/connection.py
@@ -619,7 +619,7 @@ def _connect_attempt(self, host, hostip, port, retry):
             self.ping_outstanding.clear()
             last_send = time.monotonic()
             with self._socket_error_handling():
-                while not self.client._stopped.is_set():
+                while True:
                     # Watch for something to read or send
                     jitter_time = random.randint(1, 40) / 100.0
                     deadline = last_send + read_timeout / 2.0 - jitter_time

diff --git a/kazoo/tests/test_client.py b/kazoo/tests/test_client.py
@@ -258,8 +258,6 @@ def test_async_auth_failure(self):
         with pytest.raises(AuthFailedError):
             client.add_auth("unknown-scheme", digest_auth)
 
-        client.stop()
-
     def test_add_auth_on_reconnect(self):
         client = self._get_client()
         client.start()