Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Periodic pings #363

Closed
wants to merge 1 commit into from
Closed

Periodic pings #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion kazoo/protocol/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
from binascii import hexlify
from contextlib import contextmanager

try:
from time import monotonic as now
except ImportError:
from time import time as now

from kazoo.exceptions import (
AuthFailedError,
ConnectionDropped,
Expand Down Expand Up @@ -515,6 +520,7 @@ def _connect_attempt(self, host, port, retry):
read_timeout, connect_timeout = self._connect(host, port)
read_timeout = read_timeout / 1000.0
connect_timeout = connect_timeout / 1000.0
last_ping_sent = None
retry.reset()
self._xid = 0
self.ping_outstanding.clear()
Expand All @@ -527,18 +533,26 @@ def _connect_attempt(self, host, port, retry):
jitter_time])
s = self.handler.select([self._socket, self._read_sock],
[], [], timeout)[0]

if not s:
if self.ping_outstanding.is_set():
self.ping_outstanding.clear()
raise ConnectionDropped(
"outstanding heartbeat ping not received")
self._send_ping(connect_timeout)
last_ping_sent = now()
elif s[0] == self._socket:
response = self._read_socket(read_timeout)
close_connection = response == CLOSE_RESPONSE
else:
self._send_request(read_timeout, connect_timeout)
send_ping = False
if not self.ping_outstanding.is_set():
if last_ping_sent is None or \
now() - last_ping_sent >= read_timeout:
send_ping = True
if send_ping:
self._send_ping(connect_timeout)
last_ping_sent = now()
self.logger.info('Closing connection to %s:%s', host, port)
client._session_callback(KeeperState.CLOSED)
return STOP_CONNECTING
Expand Down