docs: make badges link to travis and pypi #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakulpathak3
force-pushed
the
readme-badge-links
branch
from
0dfa267
to
efe2975
Compare
jeffwidman
requested changes
Oct 11, 2018
README.md
Outdated
|
|
||
|  | ||
| [](https://badge.fury.io/py/kazoo) |
There was a problem hiding this comment.
I don't understand this last one:
- Why switch away from
shields.ioas the image source? - Why is the URL not pointing directly to PyPI? https://pypi.org/project/kazoo/
There was a problem hiding this comment.
- Didn't realize that it was a badge service (thought it was maybe just a static image host or something) until you mentioned it.
badge.fury.ioautomatically redirects to PyPi kazoo. It's just the default way to use them as mentioned in their docs.
I've added a commit to switch back to shields.io and just fix the link instead after reading your comment though.
jeffwidman
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the badges just open a static image of the badges. This makes it so that it opens the actual links to latest travis build and PyPi instead.
Updated README.
For context: https://docs.travis-ci.com/user/status-images/ this is where I got the Travis link button command.
And https://badge.fury.io/for/py/kazoo for the PyPi badge.
Update: Moved to using shields.io like it was before instead of badge.fury. Here's the README with shields.io.