-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(recipe):No more memory leak when ChildrenWatch was stopped #543
fix(recipe):No more memory leak when ChildrenWatch was stopped #543
Conversation
5bb45b1
to
c97a16c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Is it possible to add a test for this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is great, I just added some comments
@kulallwang thanks again for your PR, this is now on master. |
fix(recipe): No more memory leak when ChildrenWatch was stopped (python-zk#543)
Remove session watcher from the listener when ChildrenWatch was stopped