Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recipe):No more memory leak when ChildrenWatch was stopped #543

Merged

Conversation

kulallwang
Copy link
Contributor

Remove session watcher from the listener when ChildrenWatch was stopped

@kulallwang kulallwang closed this Dec 4, 2018
@kulallwang kulallwang reopened this Dec 4, 2018
@kulallwang kulallwang closed this Dec 4, 2018
@kulallwang kulallwang reopened this Dec 4, 2018
Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is it possible to add a test for this case?

Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is great, I just added some comments

kazoo/tests/test_watchers.py Outdated Show resolved Hide resolved
kazoo/tests/test_watchers.py Outdated Show resolved Hide resolved
kazoo/tests/test_watchers.py Outdated Show resolved Hide resolved
@StephenSorriaux StephenSorriaux merged commit 37bcda3 into python-zk:master Dec 6, 2018
@StephenSorriaux
Copy link
Member

@kulallwang thanks again for your PR, this is now on master.

kulallwang added a commit to kulallwang/kazoo that referenced this pull request Dec 6, 2018
fix(recipe): No more memory leak when ChildrenWatch was stopped (python-zk#543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants