Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant wheel dep from pyproject.toml #671

Merged
merged 1 commit into from Oct 9, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Oct 8, 2022

Why is this needed?

Remove the redundant wheel dependency, as it is added by the backend automatically. Listing it explicitly in the documentation was a historical mistake and has been fixed since, see: pypa/setuptools@f7d30a9

Proposed Changes

  • remove wheel from pyproject.toml

Does this PR introduce any breaking change?

No.

Remove the redundant `wheel` dependency, as it is added by the backend
automatically.  Listing it explicitly in the documentation was
a historical mistake and has been fixed since, see:
pypa/setuptools@f7d30a9

Signed-off-by: Michał Górny <mgorny@gentoo.org>
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Base: 94.42% // Head: 94.53% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (1d053fe) compared to base (bd62797).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   94.42%   94.53%   +0.10%     
==========================================
  Files          57       57              
  Lines        8399     8399              
==========================================
+ Hits         7931     7940       +9     
+ Misses        468      459       -9     
Impacted Files Coverage Δ
kazoo/tests/test_client.py 98.70% <0.00%> (-0.10%) ⬇️
kazoo/protocol/connection.py 96.49% <0.00%> (+0.61%) ⬆️
kazoo/tests/test_cache.py 59.86% <0.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@StephenSorriaux StephenSorriaux merged commit 161c687 into python-zk:master Oct 9, 2022
@mgorny mgorny deleted the wheel branch October 9, 2022 19:05
@mgorny
Copy link
Contributor Author

mgorny commented Oct 9, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants