Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): follow http redirect and use https mirror #745

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

StephenSorriaux
Copy link
Member

@StephenSorriaux StephenSorriaux commented Feb 25, 2024

So that we can perform testing again and better understand when this step fails.

Why is this needed?

So that ZK can be downloaded again during testing suite.

Proposed Changes

  • display a little more information when the step fails
  • follow http redirect
  • use https mirror

Does this PR introduce any breaking change?

No

@StephenSorriaux StephenSorriaux changed the title feat(testing): be a little more verbose about ZK download URL fix(testing): follow http redirect and use https mirror Feb 25, 2024
@StephenSorriaux StephenSorriaux marked this pull request as ready for review February 25, 2024 17:39
@StephenSorriaux StephenSorriaux merged commit b4155ea into master Feb 26, 2024
28 checks passed
@StephenSorriaux StephenSorriaux deleted the fix/zk-download branch February 26, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants