Temporarily remove 3.12 from the python-version list in CI workflow.
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Aug 15, 2023
|
This still fails with: which is the problem mentioned in #330 (aio-libs/aiohttp#7229). Ok to remove |
I don't think there's any other option if we want to keep the CI green, unfortunately. I've hit the aiohttp issue in a few other projects, as well :/ |
|
Yes, let's remove it! (We can have a draft PR to add it back instead.) |
ezio-melotti
commented
Aug 15, 2023
| @@ -24,6 +24,7 @@ jobs: | |||
| uses: actions/setup-python@v4 | |||
| with: | |||
| python-version: ${{ matrix.python-version }} | |||
| allow-prereleases: true | |||
There was a problem hiding this comment.
I left this here so that we don't forget, but I could also remove it and it to the draft PR that adds 3.12 back if you prefer:
Suggested change
| allow-prereleases: true |
There was a problem hiding this comment.
I think it's fine to leave it in
AlexWaygood
approved these changes
Aug 15, 2023
ezio-melotti
changed the title
python-version list in CI workflow.3.12 from the python-version list in CI workflow.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the CI failures that are blocking other PRs.
#348 and #349 are failing with:
and
onexcwas introduced in3.12, but possibly after the alpha that is currently pinned.However bumping it to
3.12will probably cause other issues (like the ones seen in #330), so this is just an attempt to see if it works, and if not I'm planning to just remove3.12altogether for the time being.