Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest-asyncio as a dev requirement so we don't skip so many tests in CI #358

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Oct 9, 2023

Currently, all async def test functions are being skipped: see the CI runs in https://github.com/python/blurb_it/actions/runs/6453980405/job/17518591042 for an example. With pytest-asyncio installed, these are no longer skipped!

We also need to add asyncio_mode=auto to the pytest config in order for this plugin to do its job, which necessitated adding a pytest config. So I did that as well, and enhanced the coveragepy config while I was about it.

@AlexWaygood AlexWaygood merged commit b7be839 into python:main Oct 9, 2023
6 checks passed
@AlexWaygood AlexWaygood deleted the dont-skip-tests branch October 9, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants