Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-gil test flag to Windows NoGIL builder #458

Merged
merged 1 commit into from Jan 22, 2024

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented Jan 22, 2024

since python/cpython#113129 (part of python/cpython#112984), we need to pass --disable-gil to rt.bat too

@itamaro itamaro requested a review from zooba January 22, 2024 19:19
@itamaro itamaro merged commit 8906549 into python:main Jan 22, 2024
1 check passed
@zooba
Copy link
Member

zooba commented Jan 22, 2024

Not sure if this passes it to rt.bat or Tools\buildbot\test.bat, but if it's the latter, we'll need to update the test.bat script to pass it through.

@itamaro
Copy link
Contributor Author

itamaro commented Jan 22, 2024

Not sure if this passes it to rt.bat or Tools\buildbot\test.bat, but if it's the latter, we'll need to update the test.bat script to pass it through.

based on my limited understanding of batch scripts, this would add the --disable-gil flag to regrtest_args, which would then be handed off to rt.bat here.

it does look like recent builds are now failing in a different way (many link.exe failures from test_peg_generator).

@itamaro itamaro deleted the windows-nogil-test-flags branch January 23, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants