Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onder-riscv64 #474

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Add onder-riscv64 #474

merged 3 commits into from
Mar 10, 2024

Conversation

furkanonder
Copy link
Contributor

No description provided.

@vstinner
Copy link
Member

vstinner commented Mar 9, 2024

@zware: Did you send a password to @furkanonder?

@itamaro
Copy link
Contributor

itamaro commented Mar 10, 2024

@zware: Did you send a password to @furkanonder?

I see the settings yaml file on the master doesn't have an entry yet for furkanonder. I can set up a password and send him shortly.

Comment on lines 317 to 321
cpw(
name="onder-riscv64",
tags=['linux', 'unix', 'ubuntu', 'riscv64'],
parallel_tests=4,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all branches working on riscv64? (going back all the way to 3.9)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.12

== Tests result: SUCCESS ==

12 tests skipped:
    test.test_asyncio.test_windows_events
    test.test_asyncio.test_windows_utils test_devpoll test_ioctl
    test_kqueue test_launcher test_msilib test_perf_profiler
    test_startfile test_winconsoleio test_winreg test_wmi

12 tests skipped (resource denied):
    test_curses test_ossaudiodev test_smtpnet test_socketserver
    test_tix test_tkinter test_ttk test_urllib2net test_urllibnet
    test_winsound test_xmlrpc_net test_zipfile64

464 tests OK.

Total duration: 35 min 22 sec
Total tests: run=41,982 skipped=1,342
Total test files: run=476/488 skipped=12 resource_denied=12
Result: SUCCESS

3.11

== Tests result: SUCCESS ==

10 tests skipped:
    test.test_asyncio.test_windows_events
    test.test_asyncio.test_windows_utils test_devpoll test_ioctl
    test_kqueue test_launcher test_msilib test_startfile
    test_winconsoleio test_winreg

12 tests skipped (resource denied):
    test_curses test_ossaudiodev test_smtpnet test_socketserver
    test_tix test_tk test_ttk_guionly test_urllib2net test_urllibnet
    test_winsound test_xmlrpc_net test_zipfile64

461 tests OK.

Total duration: 26 min 52 sec
Total tests: run=40,604 skipped=1,355
Total test files: run=471/483 skipped=10 resource_denied=12
Result: SUCCESS

3.10

== Tests result: FAILURE ==

405 tests OK.

1 test failed:
    test_email

19 tests skipped:
    test_curses test_devpoll test_ioctl test_kqueue test_msilib
    test_ossaudiodev test_smtpnet test_socketserver test_startfile
    test_tix test_tk test_ttk_guionly test_urllib2net test_urllibnet
    test_winconsoleio test_winreg test_winsound test_xmlrpc_net
    test_zipfile64

Total duration: 29 min 31 sec
Tests result: FAILURE

3.9

== Tests result: FAILURE ==

405 tests OK.

1 test failed:
    test_email

19 tests skipped:
    test_curses test_devpoll test_ioctl test_kqueue test_msilib
    test_ossaudiodev test_smtpnet test_socketserver test_startfile
    test_tix test_tk test_ttk_guionly test_urllib2net test_urllibnet
    test_winconsoleio test_winreg test_winsound test_xmlrpc_net
    test_zipfile64

Total duration: 32 min 59 sec
Tests result: FAILURE

There is only one failed test case on branches 3.10 and 3.9.

test test_email failed -- Traceback (most recent call last):
  File "/home/ubuntu/cpython/Lib/test/support/__init__.py", line 771, in inner
    return func(*args, **kwds)
  File "/home/ubuntu/cpython/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'Europe' != 'MSK'
- Europe
+ MSK

== Tests result: FAILURE ==

1 test failed:
    test_email

Total duration: 27.9 sec
Tests result: FAILURE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9 and 3.10 branches are in security status. Do we need to fix the tests in this case? @itamaro

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, excluding those branches is the right thing to do.

@@ -279,6 +279,9 @@
# FreBSD x86-64 clang
# FreeBSD 15 is CURRENT: development branch (at 2023-10-17)
("AMD64 FreeBSD15", "opsec-fbsd15", UnixBuild),

# riscv64 GCC
("riscv64 Ubuntu23", "onder-riscv64", UnixBuild),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is for Tier-3, but to get Tier-3, you need one core dev responsible of this platform. I suggest to start with No-Tier for now, it's not a big difference.

@vstinner
Copy link
Member

Related issue: #473

Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@itamaro itamaro merged commit 71c6023 into python:main Mar 10, 2024
1 check passed
@vstinner
Copy link
Member

The worker works as expected and the first build is a success, nice! https://buildbot.python.org/all/#/builders/1379/builds/1

@vstinner
Copy link
Member

@furkanonder: I cannot support such platform unless I have access to it or access to another RISC-V machine. Moreover, I'm not really volunteer to support it :-) But you can ping me if you need help to investigate some issues.

Congrats for running your worker :-) Long life to this new cool CPU ISA !

@furkanonder
Copy link
Contributor Author

@furkanonder: I cannot support such platform unless I have access to it or access to another RISC-V machine. Moreover, I'm not really volunteer to support it :-) But you can ping me if you need help to investigate some issues.

Congrats for running your worker :-) Long life to this new cool CPU ISA !

Thank you so much for your time and efforts! @vstinner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants