Remove multiple commit prefixes #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+883
to
+886
| m = re.search(r"\d+(?:\.\d+)+", branch) | ||
| if not m: | ||
| raise ValueError(f"Branch {branch} seems to not have a version in its name.") | ||
| return tuple(map(int, m[0].split("."))) |
There was a problem hiding this comment.
This is a pure refactoring (and optimization).
| split_commit_message = commit_message.split("\n") | ||
| title = split_commit_message[0] | ||
| body = "\n".join(split_commit_message[1:]) | ||
| title, _, body = commit_message.partition("\n") |
There was a problem hiding this comment.
This is a pure refactoring (and optimization).
Multiple commit prefixes "[X.Y] " were added in multilevel backports. Only the leftmost one matters. Others just increase the length of the title.
serhiy-storchaka
force-pushed
the
remove-commit-prefix
branch
from
d9ab2de
to
033bb60
Compare
hugovk
reviewed
Feb 13, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple commit prefixes "[X.Y] " were added in multilevel backports. Only the leftmost one matters. Others just increase the length of the title.
Fixes #117.