Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-picker] Document config options #249

Closed
webknjaz opened this issue May 23, 2018 · 4 comments
Closed

[cherry-picker] Document config options #249

webknjaz opened this issue May 23, 2018 · 4 comments

Comments

@webknjaz
Copy link
Contributor

Now that this tool supports working with other repos I wanted to check how can I use it in other project.

It took me a while to realize that check_sha should contain very fist commit in a repo's main branch. So I suggest documenting the config usage somewhere in README.

@Mariatta
Copy link
Member

Mariatta commented Jun 2, 2018

It is documented under "Available config options" here?

@webknjaz
Copy link
Contributor Author

webknjaz commented Jun 2, 2018

Oh, I think I missed that, thanks. But still I'm not sure what is the purpose of it.

@Mariatta
Copy link
Member

Mariatta commented Jun 2, 2018

Just a way to ensure that we are operating on the right repo, before even starting to do git fetch, checkout, etc.
It can be any commit hash in your repo. We picked the first ever commit to CPython, we know it won't be amended or dropped ever.

@Mariatta
Copy link
Member

Mariatta commented Jun 2, 2018

I'm closing your issue since it's been documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants