Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cherry-picker's README to treat it as a package #89

Closed
brettcannon opened this issue May 13, 2017 · 0 comments
Closed

Change cherry-picker's README to treat it as a package #89

brettcannon opened this issue May 13, 2017 · 0 comments

Comments

@brettcannon
Copy link
Member

If you look at the README for cherry-picker, the instructions tell you to treat it as a module, i.e. python3 -m cherry-picker while in the cherry-picker directory. But everything else about the code wants it to be treated as a package, e.g. __main__.py uses relative imports so you can't do python3 . to execute cherry-picker.

If cherry-picker is going to be a package then I think the instructions should probably be updated to uniformly treat it as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant