Skip to content

Commit

Permalink
Issue #16564: Fixed a performance regression relative to Python 3.1 i…
Browse files Browse the repository at this point in the history
…n the

caching of compiled regular expressions.
  • Loading branch information
serhiy-storchaka committed Mar 16, 2013
1 parent de6849f commit 0f606a6
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 9 deletions.
34 changes: 25 additions & 9 deletions Lib/re.py
Expand Up @@ -215,8 +215,8 @@ def compile(pattern, flags=0):

def purge():
"Clear the regular expression caches"
_compile_typed.cache_clear()
_compile_repl.cache_clear()
_cache.clear()
_cache_repl.clear()

def template(pattern, flags=0):
"Compile a template pattern, returning a pattern object"
Expand Down Expand Up @@ -257,27 +257,43 @@ def escape(pattern):
# --------------------------------------------------------------------
# internals

_cache = {}
_cache_repl = {}

_pattern_type = type(sre_compile.compile("", 0))

def _compile(pattern, flags):
return _compile_typed(type(pattern), pattern, flags)
_MAXCACHE = 512

@functools.lru_cache(maxsize=500)
def _compile_typed(text_bytes_type, pattern, flags):
def _compile(pattern, flags):
# internal: compile pattern
try:
return _cache[type(pattern), pattern, flags]
except KeyError:
pass
if isinstance(pattern, _pattern_type):
if flags:
raise ValueError(
"Cannot process flags argument with a compiled pattern")
return pattern
if not sre_compile.isstring(pattern):
raise TypeError("first argument must be string or compiled pattern")
return sre_compile.compile(pattern, flags)
p = sre_compile.compile(pattern, flags)
if len(_cache) >= _MAXCACHE:
_cache.clear()
_cache[type(pattern), pattern, flags] = p
return p

@functools.lru_cache(maxsize=500)
def _compile_repl(repl, pattern):
# internal: compile replacement pattern
return sre_parse.parse_template(repl, pattern)
try:
return _cache_repl[repl, pattern]
except KeyError:
pass
p = sre_parse.parse_template(repl, pattern)
if len(_cache_repl) >= _MAXCACHE:
_cache_repl.clear()
_cache_repl[repl, pattern] = p
return p

def _expand(pattern, match, template):
# internal: match.expand implementation hook
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS
Expand Up @@ -233,6 +233,9 @@ Core and Builtins
Library
-------

- Issue #16564: Fixed a performance regression relative to Python 3.1 in the
caching of compiled regular expressions.

- Issue #17431: Fix missing import of BytesFeedParser in email.parser.

- Issue #1285086: Get rid of the refcounting hack and speed up
Expand Down

0 comments on commit 0f606a6

Please sign in to comment.