Simplify writing of _PyOpcode_Caches

python · Sep 8, 2023 · 1850988 · 1850988
1 parent ed045d7
commit 1850988
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/Include/internal/pycore_opcode_metadata.h b/Include/internal/pycore_opcode_metadata.h
diff --git a/Tools/cases_generator/generate_cases.py b/Tools/cases_generator/generate_cases.py
@@ -550,15 +550,12 @@ def write_metadata(self, metadata_filename: str, pymetadata_filename: str) -> No
                 ";",
             ):
                 family_member_names: set[str] = set()
-                for name, family in self.families.items():
+                for family in self.families.values():
                     family_member_names.update(family.members)
-                    instr = self.instrs[name]
-                    if instr.cache_offset > 0:
-                        self.out.emit(f"[{name}] = {instr.cache_offset},")
                 for instr in self.instrs.values():
                     if (
-                        not instr.family
-                        and instr.cache_offset
+                        instr.name not in family_member_names
+                        and instr.cache_offset > 0
                         and instr.kind == "inst"
                         and not instr.name.startswith("INSTRUMENTED_")
                     ):