Skip to content

Commit

Permalink
bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS. (#…
Browse files Browse the repository at this point in the history
…462) (#973)

* bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS

Skip some tests of select.poll when running on macOS due to unresolved
issues with the underlying system poll function on some macOS versions.

(cherry picked from commit de04644)
  • Loading branch information
vstinner committed Apr 3, 2017
1 parent d64146c commit 23d6eb6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Lib/test/test_asyncore.py
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,9 @@ def test_handle_expt(self):
# Note: this might fail on some platforms as OOB data is
# tenuously supported and rarely used.

if sys.platform == "darwin" and self.use_poll:
self.skipTest("poll may fail on macOS; see issue #28087")

class TestClient(BaseClient):
def handle_expt(self):
self.flag = True
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ Build
Tests
-----

- bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS.
Skip some tests of select.poll when running on macOS due to unresolved
issues with the underlying system poll function on some macOS versions.

- bpo-15083: Convert ElementTree doctests to unittests.


Expand Down

0 comments on commit 23d6eb6

Please sign in to comment.