bpo-39055: Reject a trailing \n in base64.b64decode() with validate=T…

…rue. (GH-17616)

(cherry picked from commit b19c0d7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Lib/base64.py

@@ -82,7 +82,7 @@ def b64decode(s, altchars=None, validate=False):
         altchars = _bytes_from_decode_data(altchars)
         assert len(altchars) == 2, repr(altchars)
         s = s.translate(bytes.maketrans(altchars, b'+/'))
-    if validate and not re.match(b'^[A-Za-z0-9+/]*={0,2}$', s):
+    if validate and not re.fullmatch(b'[A-Za-z0-9+/]*={0,2}', s):
         raise binascii.Error('Non-base64 digit found')
     return binascii.a2b_base64(s)
 

Lib/test/test_base64.py

@@ -250,6 +250,7 @@ def test_b64decode_invalid_chars(self):
                  (b'3d}==', b'\xdd'),
                  (b'@@', b''),
                  (b'!', b''),
+                 (b"YWJj\n", b"abc"),
                  (b'YWJj\nYWI=', b'abcab'))
         funcs = (
             base64.b64decode,

Misc/NEWS.d/next/Library/2019-12-15-19-23-23.bpo-39055.FmN3un.rst

@@ -0,0 +1,2 @@
+:func:`base64.b64decode` with ``validate=True`` raises now a binascii.Error
+if the input ends with a single ``\n``.