Skip to content

Commit

Permalink
[3.12] gh-114149: [Enum] revert GH-114196 and add more tuple-subclass…
Browse files Browse the repository at this point in the history
… tests (GH-114215) (GH-114218)

gh-114149: [Enum] revert GH-114160 and add more tuple-subclass tests (GH-114215)

This reverts commit 05e142b.
(cherry picked from commit 4c7e09d)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
  • Loading branch information
miss-islington and ethanfurman committed Jan 18, 2024
1 parent 87198f6 commit 35e330b
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 9 deletions.
6 changes: 3 additions & 3 deletions Lib/enum.py
Expand Up @@ -254,7 +254,7 @@ def __set_name__(self, enum_class, member_name):
delattr(enum_class, member_name)
# second step: create member based on enum_class
value = self.value
if type(value) is not tuple:
if not isinstance(value, tuple):
args = (value, )
else:
args = value
Expand Down Expand Up @@ -1757,7 +1757,7 @@ def convert_class(cls):
else:
# create the member
if use_args:
if type(value) is not tuple:
if not isinstance(value, tuple):
value = (value, )
member = new_member(enum_class, *value)
value = value[0]
Expand Down Expand Up @@ -1807,7 +1807,7 @@ def convert_class(cls):
else:
# create the member
if use_args:
if type(value) is not tuple:
if not isinstance(value, tuple):
value = (value, )
member = new_member(enum_class, *value)
value = value[0]
Expand Down
27 changes: 21 additions & 6 deletions Lib/test/test_enum.py
Expand Up @@ -3163,19 +3163,34 @@ class NTEnum(Enum):
[x.value for x in NTEnum],
[TTuple(id=0, a=0, blist=[]), TTuple(id=1, a=2, blist=[4]), TTuple(id=2, a=4, blist=[0, 1, 2])],
)

self.assertRaises(AttributeError, getattr, NTEnum.NONE, 'id')
#
class NTCEnum(TTuple, Enum):
NONE = 0, 0, []
A = 1, 2, [4]
B = 2, 4, [0, 1, 2]
self.assertEqual(repr(NTCEnum.NONE), "<NTCEnum.NONE: TTuple(id=0, a=0, blist=[])>")
self.assertEqual(NTCEnum.NONE.value, TTuple(id=0, a=0, blist=[]))
self.assertEqual(NTCEnum.NONE.id, 0)
self.assertEqual(NTCEnum.A.a, 2)
self.assertEqual(NTCEnum.B.blist, [0, 1 ,2])
self.assertEqual(
[x.value for x in NTCEnum],
[TTuple(id=0, a=0, blist=[]), TTuple(id=1, a=2, blist=[4]), TTuple(id=2, a=4, blist=[0, 1, 2])],
)
#
class NTDEnum(Enum):
def __new__(cls, t_value):
def __new__(cls, id, a, blist):
member = object.__new__(cls)
member._value_ = t_value[0]
member.id = t_value[0]
member.a = t_value[1]
member.blist = t_value[2]
member.id = id
member.a = a
member.blist = blist
return member
NONE = TTuple(0, 0, [])
A = TTuple(1, 2, [4])
B = TTuple(2, 4, [0, 1, 2])
self.assertEqual(repr(NTDEnum.NONE), "<NTDEnum.NONE: 0>")
self.assertEqual(repr(NTDEnum.NONE), "<NTDEnum.NONE: TTuple(id=0, a=0, blist=[])>")
self.assertEqual(NTDEnum.NONE.id, 0)
self.assertEqual(NTDEnum.A.a, 2)
self.assertEqual(NTDEnum.B.blist, [0, 1 ,2])
Expand Down

0 comments on commit 35e330b

Please sign in to comment.