Skip to content

Commit

Permalink
bpo-43224: Add TypeVarTuple.__name__ (GH-31954)
Browse files Browse the repository at this point in the history
I noticed that TypeVar and ParamSpec put their name in a __name__
attribute, but TypeVarTuple doesn't. Let's be consistent.
  • Loading branch information
JelleZijlstra committed Mar 18, 2022
1 parent d0a91bd commit 3a2b895
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 11 deletions.
15 changes: 6 additions & 9 deletions Lib/test/test_typing.py
Expand Up @@ -415,6 +415,12 @@ def assertEndsWith(self, string, tail):
if not string.endswith(tail):
self.fail(f"String {string!r} does not end with {tail!r}")

def test_name(self):
Ts = TypeVarTuple('Ts')
self.assertEqual(Ts.__name__, 'Ts')
Ts2 = TypeVarTuple('Ts2')
self.assertEqual(Ts2.__name__, 'Ts2')

def test_instance_is_equal_to_itself(self):
Ts = TypeVarTuple('Ts')
self.assertEqual(Ts, Ts)
Expand Down Expand Up @@ -509,15 +515,6 @@ def test_repr_is_correct(self):
self.assertEqual(repr(Unpack[tuple[Unpack[Ts]]]), '*tuple[*Ts]')
self.assertEqual(repr(Unpack[Tuple[Unpack[Ts]]]), '*typing.Tuple[*Ts]')

def test_repr_is_correct(self):
Ts = TypeVarTuple('Ts')
self.assertEqual(repr(Ts), 'Ts')
self.assertEqual(repr(Unpack[Ts]), '*Ts')
self.assertEqual(repr(tuple[Unpack[Ts]]), 'tuple[*Ts]')
self.assertEqual(repr(Tuple[Unpack[Ts]]), 'typing.Tuple[*Ts]')
self.assertEqual(repr(Unpack[tuple[Unpack[Ts]]]), '*tuple[*Ts]')
self.assertEqual(repr(Unpack[Tuple[Unpack[Ts]]]), '*typing.Tuple[*Ts]')

def test_variadic_class_repr_is_correct(self):
Ts = TypeVarTuple('Ts')
class A(Generic[Unpack[Ts]]): pass
Expand Down
4 changes: 2 additions & 2 deletions Lib/typing.py
Expand Up @@ -939,13 +939,13 @@ class C(Generic[*Ts]): ...
"""

def __init__(self, name):
self._name = name
self.__name__ = name

def __iter__(self):
yield Unpack[self]

def __repr__(self):
return self._name
return self.__name__

def __typing_subst__(self, arg):
raise AssertionError
Expand Down

0 comments on commit 3a2b895

Please sign in to comment.