Skip to content

Commit

Permalink
bpo-46510: update Python2-style exception handling in argparse (GH-30881
Browse files Browse the repository at this point in the history
)
  • Loading branch information
kumaraditya303 committed Jan 25, 2022
1 parent ee60550 commit 45f5f52
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions Lib/argparse.py
Expand Up @@ -1875,8 +1875,7 @@ def parse_known_args(self, args=None, namespace=None):
if self.exit_on_error:
try:
namespace, args = self._parse_known_args(args, namespace)
except ArgumentError:
err = _sys.exc_info()[1]
except ArgumentError as err:
self.error(str(err))
else:
namespace, args = self._parse_known_args(args, namespace)
Expand Down Expand Up @@ -2151,8 +2150,7 @@ def _read_args_from_files(self, arg_strings):
arg_strings.append(arg)
arg_strings = self._read_args_from_files(arg_strings)
new_arg_strings.extend(arg_strings)
except OSError:
err = _sys.exc_info()[1]
except OSError as err:
self.error(str(err))

# return the modified argument list
Expand Down Expand Up @@ -2502,9 +2500,9 @@ def _get_value(self, action, arg_string):
result = type_func(arg_string)

# ArgumentTypeErrors indicate errors
except ArgumentTypeError:
except ArgumentTypeError as err:
name = getattr(action.type, '__name__', repr(action.type))
msg = str(_sys.exc_info()[1])
msg = str(err)
raise ArgumentError(action, msg)

# TypeErrors or ValueErrors also indicate errors
Expand Down

0 comments on commit 45f5f52

Please sign in to comment.